Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dc_has_unnoticed_chats() and dc_marknoticed_all_chats() #5825

Closed
Simon-Laux opened this issue Jul 31, 2024 · 2 comments
Closed

add dc_has_unnoticed_chats() and dc_marknoticed_all_chats() #5825

Simon-Laux opened this issue Jul 31, 2024 · 2 comments
Assignees

Comments

@Simon-Laux
Copy link
Member

Simon-Laux commented Jul 31, 2024

to fix this "bug" in desktop: deltachat/deltachat-desktop#3979

if these information are not easily available in the UI, we should consider adding dedicated core functions as dc_has_unnoticed_chats() and dc_marknoticed_all_chats() (due to multiple meanings, we avoid the the term "read" in the api, cmp)

~ deltachat/deltachat-desktop#3979 (comment)

mainly important to have them in the jsonrpc api because thats what desktop uses

@Septias
Copy link
Collaborator

Septias commented Oct 20, 2024

Actually it should be enough to use getFreshMsgCnt in this line https://github.com/deltachat/deltachat-desktop/blob/f9b5e1290832bd45c82d9df70ee91f38884b93df/src/renderer/components/AccountListSidebar/AccountItem.tsx#L45
as getFreshMsgs filters out muted chats and getFreshMsgCnt does not. It also produces less traffic which is good.
No new API needed IMO, feel free to reopen if you disagree.

@Septias Septias closed this as completed Oct 20, 2024
@r10s
Copy link
Member

r10s commented Oct 21, 2024

getFreshMsgCnt() is per-chat - not sure if that is the best way to help showing/hiding a menu entry in desktop's account sidebar, maybe i've overseen a simple things :)

but agree with closing the issue for now (even though i proposed the APIs that time :) it would be pretty special APIs for few benefits. let's discuss this in the original issue, i added an alternative idea there

@iequidoo iequidoo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants