-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced options to configure certificate checks #1036
Comments
You probably need to first add the constants to deltachat-node and update the rust core there. Can help you with this, if you want we can also do an audio/video hack session on this. |
I did not any constants to FFI, going to use |
cmp question at deltachat/deltachat-ios#322 i think it is important to keep the non-power-users in mind. there are tons of self-signed click-hosters eg. here in germany. so we have to choose the defaults very carefully. i think the idea @hpk42 pointed out somewhere else is reasonable: be lazy on default - but if we know due to the provider-database or by other sources (maybe autoconfigure) that the certificatiate should be good, we should check that. i do not think it is of much worth to check always and scare the users even before they're really onboarded. i think we do not need this additional ux barrier currently. |
This setting goes into advanced settings, so users who want certificate checking can select "strict" mode. Default option is |
This appears to have been implemented, closing it. |
Since options
imap_certificate_checks
andsmtp_certificate_checks
were added to the Rust core in deltachat/deltachat-core-rust#647 they need to be added to the Desktop client.Going to try to do it myself.
The text was updated successfully, but these errors were encountered: