Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Make it possible to configure {imap,smtp}_certificate_checks #388

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Make it possible to configure {imap,smtp}_certificate_checks #388

merged 1 commit into from
Oct 31, 2019

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Oct 27, 2019

No description provided.

@link2xt
Copy link
Contributor Author

link2xt commented Oct 27, 2019

WIP, waiting for deltachat/deltachat-core-rust#751

After that, constants need to be generated.

@link2xt
Copy link
Contributor Author

link2xt commented Oct 28, 2019

I have updated core in this branch.

So far my attempts to use this branch with Desktop (via npm link) result in segfaults. Electron starts, print the logfile name and dies with SIGSEGV. Log file is empty.

@Jikstra
Copy link
Collaborator

Jikstra commented Oct 28, 2019

So far my attempts to use this branch with Desktop (via npm link) result in segfaults. Electron starts, print the logfile name and dies with SIGSEGV. Log file is empty.

Ay. Currently i'm on mobile internet so can't do big pulls. I will give this a try but would refuse to merge this until that segfault is fixed. Thanks for pushing the certificate checks, i like this! I will be a bit off until the first november, hope to be able to review your prs until then but probably it won't happen before the first. @ralphtheninja maybe you can help out?

link2xt referenced this pull request Oct 28, 2019
@link2xt
Copy link
Contributor Author

link2xt commented Oct 28, 2019

@Jikstra @Simon-Laux already updated it, the question now is if it works with Desktop. Going to test later today.

@link2xt
Copy link
Contributor Author

link2xt commented Oct 28, 2019

Rebased the PR.

Just tested it, did git clean -xffd ., removed all submodules etc. First built desktop repo as usual, ran it. Then did npm link ../deltachat-node and rebuilt it.

It works! Now I am not sure what the problem was, maybe different parts of code were compiled with different values of DC_STR_COUNT. Can't reproduce it anymore to run under gdb.

I entered my login and password, opened advanced settings, entered SMTP password again (otherwise login button does not activate, I am not sure that is correct behaviour, maybe remove this check?) and selected "strict" twice.

The result of sqlite3 ~/.config/DeltaChat/*/db.sqlite 'select * from config where not keyname like "%_pw"' is:

...
10|imap_certificate_checks|1
12|smtp_certificate_checks|1
...
23|configured_imap_certificate_checks|1
...
28|configured_smtp_certificate_checks|1

1 means DC_CERTCK_STRICT

Also update core to have DC_CERTCK_ constants
@Jikstra Jikstra merged commit 6c301b3 into deltachat:master Oct 31, 2019
@link2xt link2xt deleted the certificate_checks branch October 31, 2019 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants