Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add dc_set_stock_translation support #389

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add dc_set_stock_translation support #389

merged 1 commit into from
Oct 31, 2019

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Oct 28, 2019

No description provided.

@link2xt
Copy link
Contributor Author

link2xt commented Oct 28, 2019

Going to fix the failing test here. Since deltachat/deltachat-core-rust@b82af9f and core update e242774 one of the test is failing.

@link2xt link2xt marked this pull request as ready for review October 28, 2019 23:34
@link2xt
Copy link
Contributor Author

link2xt commented Oct 28, 2019

This is a breaking change, some UPGRADING.md change is needed along with a new tag, but otherwise I think it is ready.

Constants are not updated here because they are updated in #388

Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work of removing lots of code :)

@@ -1,100 +0,0 @@
// TODO remove this file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file actually asked me to remove itself

Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ralphtheninja ralphtheninja merged commit ce8f9da into deltachat:master Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants