Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrapping of icons in BaselineStatus #163

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

mayank99
Copy link
Contributor

@mayank99 mayank99 commented Nov 2, 2024

I noticed that the browser icons start wrapping in an undesired way, because of the max-width.

So I removed the max-width.

Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: b323880

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astro-community/astro-embed-baseline-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for astro-embed ready!

Name Link
🔨 Latest commit b323880
🔍 Latest deploy log https://app.netlify.com/sites/astro-embed/deploys/672638ffa777d100081e35e4
😎 Deploy Preview https://deploy-preview-163--astro-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect. This is a relic of the <baseline-status> styles which did everything with max-width and media queries. I reworked that to all wrap smoothly across viewport widths, but missed this one. Thanks for fixing!

@delucis delucis merged commit 0383e4e into delucis:main Nov 2, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 2, 2024
@mayank99 mayank99 deleted the patch-1 branch November 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants