Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark results depend on their order #232

Closed
ivan-tymoshenko opened this issue Jan 4, 2022 · 3 comments · Fixed by #233
Closed

Benchmark results depend on their order #232

ivan-tymoshenko opened this issue Jan 4, 2022 · 3 comments · Fixed by #233

Comments

@ivan-tymoshenko
Copy link
Collaborator

There is something wrong happening with benchmarks. What I can say now is if you reorder your test cases you can get different results. I can't tell right now why it's happening, there can be myriads of reasons. I wanna start with the most extreme case: the first test case executes much faster than others. I was trying to test it on my laptop and my PC and got the same results. That's why I think that the "/" route executes much faster than others #225 (it's still a unique case, but the difference is not so dramatic). I was looking through the issues/PRs where people send their benchmarks and sometimes I saw the same picture (#176 (comment)). If you have the ability, please make some tests regarding the first test case. You can create multiple same tests and see if there are any differences depending on the test's place or just switch some tests and see if there is any difference.

@ivan-tymoshenko ivan-tymoshenko changed the title Benchmark result depends on their order Benchmark results depend on their order Jan 4, 2022
@mcollina
Copy link
Collaborator

mcollina commented Jan 4, 2022

Would you like to send a PR to improve the benchmark suite?

@ivan-tymoshenko
Copy link
Collaborator Author

I'm not sure what's happening. It's really hard to separate your hardware/os from V8, opt. compiler, benchmark library, etc. to find out where the problem is. So at first, I want to know if there is only my problem or not.

@mcollina
Copy link
Collaborator

mcollina commented Jan 4, 2022

you'd need to execute each test in its own process or worker thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants