Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Test Coverage to 100% #330

Closed
ivan-tymoshenko opened this issue Jun 8, 2023 · 6 comments · Fixed by #349
Closed

Get Test Coverage to 100% #330

ivan-tymoshenko opened this issue Jun 8, 2023 · 6 comments · Fixed by #349

Comments

@ivan-tymoshenko
Copy link
Collaborator

No description provided.

@ivan-tymoshenko
Copy link
Collaborator Author

@Ekott2006 Hi, I see you are interested in contributing to the project. I really appreciate it. Unfortunately, most of the issues that you can find in the backlog are stuck because they don't have a good answer or the solution doesn't worth it. You can start with this issue. We have a few uncovered lines in the project. Some of them are pretty simple, and some of them require investigation. It's a good issue problem to get familiar with the project. Tell me if you are interested, and I will assign it to you.

@Ekott2006
Copy link

Let me be honest, I have never used find-my-way before but I am interested to contribute to open source nodejs project. So what exactly am I testing?

@ivan-tymoshenko
Copy link
Collaborator Author

you can run npm test command. at the end, you will see a test coverage report. There are some lines that are not covered with tests (they marks with red color). You can create a test for them if it's possible or find the reason why they can't be covered (it's possible that there is some redundant code).

@Ekott2006
Copy link

No problem, I will come back when I face isssues

@jean-michelet
Copy link
Contributor

I can give it a try if you want @ivan-tymoshenko

@ivan-tymoshenko
Copy link
Collaborator Author

I can give it a try if you want @ivan-tymoshenko

Go ahead. This is still an actual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants