Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix short::open::tests::test_calculate_implied_rate #2

Closed
dpaiton opened this issue Apr 26, 2024 · 4 comments
Closed

fix short::open::tests::test_calculate_implied_rate #2

dpaiton opened this issue Apr 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@dpaiton
Copy link
Member

dpaiton commented Apr 26, 2024

Repeated runs of the test results in occasional failure.

`thread 'short::open::tests::test_calculate_implied_rate' panicked at crates/hyperdrive-math/src/short/open.rs:589:13:
error 107470370462233 exceeds tolerance of 100000000000000
@dpaiton
Copy link
Member Author

dpaiton commented Apr 26, 2024

This is difficult to debug until after we fix #3 and #4 because those errors are showing up more frequently than this error. I'm going to mark this as blocked until those are resolved.

@dpaiton
Copy link
Member Author

dpaiton commented Apr 30, 2024

Done: #6

@dpaiton dpaiton closed this as completed Apr 30, 2024
@dpaiton
Copy link
Member Author

dpaiton commented May 3, 2024

Reopening as it is still failing:

---- short::open::tests::test_calculate_implied_rate stdout ----
thread 'short::open::tests::test_calculate_implied_rate' panicked at crates/hyperdrive-math/src/short/open.rs:610:13:
error 144897155659882 exceeds tolerance of 100000000000000

@dpaiton dpaiton reopened this May 3, 2024
@dpaiton dpaiton removed their assignment May 3, 2024
@dpaiton dpaiton added the bug Something isn't working label May 3, 2024
@sentilesdal sentilesdal self-assigned this May 3, 2024
@dpaiton
Copy link
Member Author

dpaiton commented May 13, 2024

Resolved per @jrhea (maybe #89)

@dpaiton dpaiton closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants