Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async/await hack #360

Closed
2 tasks done
lastmjs opened this issue May 26, 2022 · 1 comment
Closed
2 tasks done

async/await hack #360

lastmjs opened this issue May 26, 2022 · 1 comment
Assignees
Milestone

Comments

@lastmjs
Copy link
Member

lastmjs commented May 26, 2022

Look into a simple transformation from async/await to generators, basically the transformations would look like this: async -> * and await -> yield.

Because our asynchronous code is currently limited to cross-canister calls, and we tightly control that functionality, it may be simple to do this replacement. Under the hood everything will be done with generators.

This hack could solve or make easier the following issues:

This is also an easier stop-gap solution for #121

@lastmjs lastmjs added this to the 1.0 milestone May 26, 2022
@lastmjs lastmjs self-assigned this May 26, 2022
@lastmjs lastmjs modified the milestones: 1.0, June May 26, 2022
@dansteren dansteren modified the milestones: June, July Jun 30, 2022
@lastmjs lastmjs modified the milestones: 0.6.0, 1.0 Jul 26, 2022
@lastmjs
Copy link
Member Author

lastmjs commented Nov 28, 2022

We have a few plausible paths forward to do this without a hack, so we are taking the idea of a hack off the table

@lastmjs lastmjs closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants