Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

'System.Runtime' which was not found in the GAC. #5

Closed
pizycki opened this issue Oct 5, 2016 · 20 comments
Closed

'System.Runtime' which was not found in the GAC. #5

pizycki opened this issue Oct 5, 2016 · 20 comments
Labels

Comments

@pizycki
Copy link
Contributor

pizycki commented Oct 5, 2016

Severity Code Description Project File Line Suppression State
Error Failed to add reference. The package 'xunit2.ioc.autofac' tried to add a framework reference to 'System.Runtime' which was not found in the GAC. This is possibly a bug in the package. Please contact the package owners for assistance.

Repro steps:

  1. create new library project (.NET 4.6)
  2. install xunit @ 2.2 beta build 3300
  3. install xunit2.ioc.autofac
@dennisroche dennisroche added the bug label Oct 6, 2016
@dennisroche
Copy link
Owner

@pizycki could you attach the new library project so that I can debug further?

Initial step to figure this out will be to download the lib and include the as a local project reference.

@pizycki
Copy link
Contributor Author

pizycki commented Oct 6, 2016

There you go
IzzyDev.Integro.zip

@RavindraBarapatre
Copy link

I am also getting same error.

@dennisroche
Copy link
Owner

I'm seeing a different error when trying to install the lib package.

Unable to find a version of 'Autofac' that is compatible with 'xunit2.ioc.autofac 1.0.2 constraint: Autofac (>= 4.1.1)'.

I'll continue to investigate.

@pizycki
Copy link
Contributor Author

pizycki commented Oct 6, 2016

Well, I haven't installed Autofac on this project.
I did it now, but nothing have changed, the problem persists.

@gitfool
Copy link

gitfool commented Nov 14, 2016

I'm hitting this as well. Any chance the proposed fix can be merged soon?

@dennisroche
Copy link
Owner

Apologies. I didn't know there was a PR up. I'll review it now.

@dennisroche
Copy link
Owner

@gitfool fix is merged and nuget package is deployed. thanks @pizycki. glad that i setup a build/deploy early on.

@gitfool
Copy link

gitfool commented Nov 14, 2016

Gotta love Cake. Cheers! 🍰

@gitfool
Copy link

gitfool commented Nov 14, 2016

@dennisroche Except that didn't make any difference. Still getting the error trying to install 1.0.3!?

@dennisroche
Copy link
Owner

@gitfool bugger. i took the fix assuming that it worked for @pizycki.

@dennisroche dennisroche reopened this Nov 14, 2016
@gitfool
Copy link

gitfool commented Nov 14, 2016

Yeah I assumed the same. The link in the PR implied it was enough. Are you able to repro with a new project targeting .NET FW 4.6.1 using the latest Autofac and xUnit prerelease?

@dennisroche
Copy link
Owner

I think I see the error with that PR - the System.Runtime needs to be added a dependency. I thought it was odd when I merged, however didn't have time to verify.

@pizycki
Copy link
Contributor Author

pizycki commented Nov 15, 2016

Weird, it worked for me. Yet, I'm .net core newbie, so I could did something wrong.
Waiting for PR from @dennisroche to be accepted.

PS: 🍰 is great !

@dennisroche
Copy link
Owner

🍰 all things. 👍

I merge the PR and deploy the 1.0.4 package. Usually would want to use pre-release tag however don't think many people are using this lib at the moment.

@dennisroche
Copy link
Owner

@pizycki the System.Runtime piece you added in needed to be listed as a dependency, outside that it would have been ignored. I think. Let's try. PR is merged.

@gitfool
Copy link

gitfool commented Nov 16, 2016

I don't see 1.0.4. Should it be available now?

@dennisroche
Copy link
Owner

I forgot to tag the build to generate the correct release number. It should be available now...

@gitfool
Copy link

gitfool commented Nov 16, 2016

I can install the package! 😉

@dennisroche
Copy link
Owner

👍 great :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants