Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Signatures lost when patch applied #35

Closed
abenzick opened this issue Aug 29, 2022 · 6 comments
Closed

Digital Signatures lost when patch applied #35

abenzick opened this issue Aug 29, 2022 · 6 comments
Assignees
Labels
question This is a request for clarification

Comments

@abenzick
Copy link

Hello,

My executable has a digital signature applied to it for my company. When tufup applies a new patch, the new executable is no longer signed. What options do we have to keep the application with a digital signature?

@dennisvang
Copy link
Owner

@abenzick Could you provide some details to help us inderstand the problem?

  • What kind of signature are we talking about, specifically?
  • How is the signature applied?
  • What is the signature used for?

@dennisvang dennisvang added the question This is a request for clarification label Aug 29, 2022
@dennisvang dennisvang self-assigned this Aug 29, 2022
@abenzick
Copy link
Author

Hello, I've attached a screenshot of what I'm referring to. Code signing certificates allow you sign your executable and indicate it comes from a trusted authority. Windows better understand the exe and offers less warning messages when it is run.

https://codesigningstore.com/how-to-digitally-sign-executable-files

Microsoft has a command line tool for signing executables:

https://docs.microsoft.com/en-us/windows/win32/seccrypto/signtool

digital_signature

@dennisvang
Copy link
Owner

@abenzick Thanks for the info.

Just to be sure: Are you certain you signed the new executable (i.e. the update) before adding it to the tufup repository?

@abenzick
Copy link
Author

@abenzick Thanks for the info.

Just to be sure: Are you certain you signed the new executable (i.e. the update) before adding it to the tufup repository?

I thought I had. I will certainly double check and give it another try.

@abenzick
Copy link
Author

@dennisvang Turns out....I did NOT sign the new (2nd) executable before I added it as a target.

When I ensured that I did, the resulting updated file had its digital signature in place. ALL GOOD :)

@dennisvang
Copy link
Owner

@abenzick That's good to hear!
Thanks for letting us know.
I was starting to get a little worried. ;-)

I'm closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question This is a request for clarification
Projects
None yet
Development

No branches or pull requests

2 participants