Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler error when strict is false #50

Closed
suguru03 opened this issue Feb 26, 2020 · 1 comment · Fixed by #51
Closed

Compiler error when strict is false #50

suguru03 opened this issue Feb 26, 2020 · 1 comment · Fixed by #51

Comments

@suguru03
Copy link
Collaborator

I'm having a compiler issue when strict is false.

{
  "compilerOptions": {
    "strict": false
  }
}

image

https://github.com/keroxp/deno-redis/blob/58a197fbbc07aa0688afad59a872d5c719c41460/redis.ts#L528-L530

It would be nice if it checks the type properly, like typeof reply !== "undefined" instead of reply != null.

I also tried only to enable strictNullChecks, but std complained. So I can't enable strict mode partially.

{
  "compilerOptions": {
    "strict": false,
    "strictNullChecks": true
  }
}
@keroxp
Copy link
Collaborator

keroxp commented Feb 27, 2020

@suguru03 PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants