Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate deno graph from deno info #10628

Open
nayeemrmn opened this issue May 13, 2021 · 2 comments
Open

Separate deno graph from deno info #10628

nayeemrmn opened this issue May 13, 2021 · 2 comments
Labels
suggestion suggestions for new features (yet to be agreed)

Comments

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented May 13, 2021

The deno info subcommand should only output cache info and for a single module at a time. We should have a separate deno graph subcommand for outputting the dependency graph of a module.

  1. The use cases for these two things are entirely separate. A large list of dependencies creates a lot of noise to sift through when you are just trying to get the location of a cache file. You never need both of these things at once.
  2. It allows more versatility for deno info. I propose that deno info doesn't implicitly invoke deno cache (which it would no longer need to), and should show null cache file paths for uncached modules. You can instead call deno cache <url> && deno info <url> for the current behaviour. This design can be applied to query the state of the cache, which partially satisfies feature requests like [Proposal] Deno command to manage modules in cache #5600.

This would be a 2.0 change.

@kitsonk kitsonk added maybe 2.0 suggestion suggestions for new features (yet to be agreed) breaking change a change or feature that breaks existing semantics labels May 13, 2021
@nayeemrmn
Copy link
Collaborator Author

This would be a 2.0 change.

It has occurred to me that the output of deno info mod.ts is merely pretty-print... and the API access deno info --json mod.ts is still marked as unstable... it's a strong argument for permitting this change in a minor release with some provisions.

Other than the proposed change the --cert, --import-map, --reload flags would be noop'd and hidden until 2.0 removal.

What do you think? @ry @kitsonk

@nayeemrmn nayeemrmn mentioned this issue Sep 17, 2021
17 tasks
@bartlomieju bartlomieju removed breaking change a change or feature that breaks existing semantics maybe 2.0 labels Mar 21, 2024
@bartlomieju
Copy link
Member

We should do it as deno info --dont-recurse. @nayeemrmn do you want to take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

3 participants