Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTimeout does not work in REPL #1161

Closed
kevinkassimo opened this issue Nov 6, 2018 · 1 comment · Fixed by #1233
Closed

setTimeout does not work in REPL #1161

kevinkassimo opened this issue Nov 6, 2018 · 1 comment · Fixed by #1233
Labels
bug Something isn't working correctly
Milestone

Comments

@kevinkassimo
Copy link
Contributor

In REPL, something like

> setTimeout(() => console.log(1), 1);

never fires

@hayd
Copy link
Contributor

hayd commented Nov 6, 2018

This is known/caused by the change from readline to being sync. @ry

Note: It would be good to test this once fixed.

Edit: I think a reasonable way to do that test is pass an optional kwarg to sleep between each input line.

deno/tools/repl_test.py

Lines 15 to 16 in 34b6b86

def input(self, *lines, **kwargs):
exit_ = kwargs.pop("exit", True)

@ry ry added the bug Something isn't working correctly label Nov 26, 2018
@ry ry added this to the v0.3 milestone Nov 26, 2018
@ry ry closed this as completed in #1233 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants