Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL multiline bug #1174

Closed
ry opened this issue Nov 8, 2018 · 6 comments
Closed

REPL multiline bug #1174

ry opened this issue Nov 8, 2018 · 6 comments

Comments

@ry
Copy link
Member

ry commented Nov 8, 2018

> ./target/debug/deno
> 1 + 2
3
> 1 + 2 +
SyntaxError: Unexpected end of input
@hayd
Copy link
Contributor

hayd commented Nov 8, 2018

Also @kevinkassimo 's report:

> var a = "{";

@hayd
Copy link
Contributor

hayd commented Nov 9, 2018

Perhaps can simply evaluate each line and if it's SyntaxError with "Unexpected end of input" message then await the next line.

Wait until after #1169 .

@kevinkassimo
Copy link
Contributor

@hayd it has pitfalls when handling things like

> eval("const a = 1; {");

@hayd
Copy link
Contributor

hayd commented Nov 9, 2018

Perhaps a --check like function to verify syntax without evaluation... Prior to evaluation.

@daynin
Copy link
Contributor

daynin commented Jan 23, 2019

I think we can do it when it's done (kkawakam/rustyline#182)

@bartlomieju
Copy link
Member

No longer happening in v0.5.0, there's still work to be done on REPL but I believe we can close this issue now.

@ry ry closed this as completed May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants