Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make cargo package work #1387

Closed
ry opened this issue Dec 21, 2018 · 2 comments
Closed

make cargo package work #1387

ry opened this issue Dec 21, 2018 · 2 comments
Labels
good first issue Good for newcomers
Milestone
v1.0

Comments

@ry
Copy link
Member

ry commented Dec 21, 2018 •
edited
Loading

"cargo package" doesn't support symlinks rust-lang/cargo#2748
-_-
https://github.com/ry/deno/tree/cargo_package
@ry ry added this to the v0.3 milestone Dec 21, 2018
@ry ry mentioned this issue Dec 21, 2018
Closed
7 tasks
@ry ry mentioned this issue Jan 9, 2019
Closed
@hayd
Copy link
Contributor

hayd commented Feb 4, 2019

Should we not use symlinks?

@ry ry mentioned this issue Feb 5, 2019
Closed
@ry ry added the good first issue Good for newcomers label Feb 7, 2019
@ry ry modified the milestones: v0.3, v0.4 Feb 12, 2019
@crlf0710
Copy link

crlf0710 commented Mar 3, 2019

I think both the package size problem and symlink problem can be resolved with splitting the code into two crates...

@piscisaureus piscisaureus mentioned this issue Mar 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
3 participants
@ry @crlf0710 @hayd