Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm compat tracking issue #17841

Closed
11 of 14 tasks
kt3k opened this issue Jan 30, 2023 · 8 comments
Closed
11 of 14 tasks

npm compat tracking issue #17841

kt3k opened this issue Jan 30, 2023 · 8 comments

Comments

@kt3k
Copy link
Member

kt3k commented Jan 30, 2023

Tracking issue for npm/node compat issues in std/node

Note: Currently we are moving Node polyfill implementation from std/node (this repository) to ext/node (Deno main repository). ref. #17724

Please wait for a while to contribute to node compat layer

High priority items

Medium priority items

Note about priorities

The priorities are higher when the issue affects popular npm modules (when used via npm: specifier).


@kt3k kt3k pinned this issue Jan 30, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Jan 31, 2023

I'll give crypto.createSecretKey() a crack.

@PolarETech
Copy link

I would like to take up promisify(execFile). I have already implemented promisify(exec), so I think this one will be ready to go soon.

@PolarETech
Copy link

PolarETech commented Feb 4, 2023

I have started to try npm:aws-cdk init.

Still investigating, but it seems to be an issue with npm:fs-extra.copy().
Because when the function runs fs.lstat(sourcefile) (== Deno.lstat(sourcefile)) to copy the file permissions, the mode value is null on Windows. In Node.js, it is possible to get the mode value.

I will comment in that issue when the information has been compiled.

@iuioiua
Copy link
Contributor

iuioiua commented Feb 11, 2023

I'll give crypto.createSecretKey() a crack.

I'm attempting crypto.Sign and crypto.Verify first.

@jacobmischka
Copy link

Just to tie together a few related other issues, the http task in high priority also affects npm:ws (#17496 (comment)) itself, and also npm:puppeteer (#17496) and npm:playwright (#16899) for some more notable packages.

@misterjoshua
Copy link

@kt3k Here's another AWS CDK-related npm compatibility issue affecting Deno 1.31.2: #18198

@barthuijgen
Copy link

Another missing feature I do not see mentioned in any of the linked issues:

Uncaught Error: Not implemented: crypto.Decipheriv.prototype.setAutoPadding

Used as

const cipher = createDecipheriv("AES-128-CBC", "key", "iv");
cipher.setAutoPadding(false);

@bartlomieju bartlomieju unpinned this issue Apr 25, 2023
@bartlomieju
Copy link
Member

Closing in favor of #18836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants