Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayBuffer missing typings for Options argument #22986

Closed
BlackAsLight opened this issue Mar 19, 2024 · 3 comments
Closed

ArrayBuffer missing typings for Options argument #22986

BlackAsLight opened this issue Mar 19, 2024 · 3 comments

Comments

@BlackAsLight
Copy link

Version: Deno 1.41.3
According to the MDN docs, the ArrayBuffer constructor takes an options argument, but those typings don't seem to exist.

const buffer = new ArrayBuffer(0, { maxByteLength: 3 }) // Expected 1 arguments, but got 2. deno-ts(2554)
buffefr.resize(1)

The .resize function should also be visible when the maxByteLength is provided.
@petamoriken
Copy link
Contributor

petamoriken commented Mar 20, 2024 •
edited
Loading

upstream PR: microsoft/TypeScript#57858

@BlackAsLight
Copy link
Author

BlackAsLight commented Mar 28, 2024 •
edited
Loading

Looks like it was merged. Just gotta wait for it to bubble up here. 🎉

Edit: nvm I'm an idiot

@BlackAsLight
Copy link
Author

#19191

@BlackAsLight BlackAsLight closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petamoriken @BlackAsLight