Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL.parse() is missing from lib.dom.d.ts #23891

Closed
nayeemrmn opened this issue May 19, 2024 · 3 comments · Fixed by #23893
Closed

URL.parse() is missing from lib.dom.d.ts #23891

nayeemrmn opened this issue May 19, 2024 · 3 comments · Fixed by #23893

Comments

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented May 19, 2024

Version: Deno 1.43.5

This affects when you have dom explicitly in your libs, or if you're using a JSX import source which includes dom types. You'll get a type checking error for using URL.parse().

Refs:

cc @petamoriken

@petamoriken
Copy link
Contributor

microsoft/TypeScript-DOM-lib-generator (lib.dom.d.ts) will automatically add the types when browser-compat-data confirms that two or more browsers have implemented them. I believe we will have to wait for URL.parse to become available in browsers other than Firefox.

@nayeemrmn
Copy link
Collaborator Author

There is plenty precedent for us updating this file in advance of the upstream, e.g. #20244.

@petamoriken
Copy link
Contributor

I get it, I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants