Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket memory leaks #27156

Open
zxch3n opened this issue Nov 29, 2024 · 0 comments · May be fixed by #27471
Open

WebSocket memory leaks #27156

zxch3n opened this issue Nov 29, 2024 · 0 comments · May be fixed by #27471
Assignees
@littledivy
Labels
ext/websocket related to the ext/websocket crate needs investigation requires further investigation before determining if it is an issue or not

Comments

@zxch3n
Copy link

zxch3n commented Nov 29, 2024

Version: Deno 2.1.2

deno/ext/websocket/01_websocket.js

Line 431 in 8626ec7

const kind = await op_ws_next_event(rid);

This line will wait even if the connection is closed locally.

Running the following code may reproduce the issue unstablely.

Deno.test("ws leak", async () => {
  const ws = new WebSocket(`validTarget`);
  await new Promise((resolve, reject) => {
    ws.addEventListener("open", resolve);
  });
  ws.close();
});

Run deno test would return the following error sometimes:

error: Leaks detected:
  - "serverWebSocket" was created during the test, but not cleaned up during the test. Close the resource before the end of the test.
  - An async operation to receive the next message on a WebSocket was started in this test, but never completed. This is often caused by not closing a `WebSocket` or `WebSocketStream`. The operation was started here:
    at op_ws_next_event (ext:core/00_infra.js:250:13)
    at WebSocket.[[[eventLoop]]] (ext:deno_websocket/01_websocket.js:431:26)
    at eventLoopTick (ext:core/01_core.js:175:7)
@bartlomieju bartlomieju added needs investigation requires further investigation before determining if it is an issue or not ext/websocket related to the ext/websocket crate labels Dec 6, 2024
@littledivy littledivy linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littledivy littledivy

Labels
ext/websocket related to the ext/websocket crate needs investigation requires further investigation before determining if it is an issue or not
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/websocket): cancel op_ws_next_event leak on close littledivy/deno
3 participants
@bartlomieju @zxch3n @littledivy