Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading Blobs #4142

Closed
morille opened this issue Feb 26, 2020 · 13 comments
Closed

Reading Blobs #4142

morille opened this issue Feb 26, 2020 · 13 comments

Comments

@morille
Copy link

morille commented Feb 26, 2020

It would be great to have either the (old) FileReader API or the new Promise based Blob methods "text", "arrayBuffer" and "stream".

@hayd
Copy link
Contributor

hayd commented Feb 27, 2020

Note: Fixing this is required for JsZip to work in deno.
(Potentially it will work OOTB with this.)

API: https://developer.mozilla.org/en-US/docs/Web/API/Blob

@crowlKats
Copy link
Member

agree, tho duplicate of #2303. I am currently looking into implementing these methods.

@brianleroux
Copy link

This would fix the browser builds for the aws-sdk in Deno also.

@crowlKats
Copy link
Member

@brianleroux this was already solved. This issue should be closed

@brianleroux
Copy link

where was it solved?
Screen Shot 2020-05-12 at 10 01 13 AM

@crowlKats
Copy link
Member

crowlKats commented May 12, 2020

FileReader API isnt implemented, but the text, arrayBuffer & stream blob methods are.

@brianleroux
Copy link

Yeah, didn't think so, but I should've been more specific. The browser builds of the aws-sdk require FileReader (and SubtleCrypto / window.cryptoAPI) so there's some gaps left to fill before closing if web compat is truly a goal.

@crowlKats
Copy link
Member

SubtleCrypto is indeed a wanted feature, just it's a decent amount of work to implement (#1891). Since this issue was made for the ability to read blobs with either of the two ways - and the goal has been reached - it should be closed. Best thing would be opening a new, more specific issue about FileReader.

@brianleroux
Copy link

sure. I don't want to make a bunch of noise opening fresh issues but knock yourself out.

@morille
Copy link
Author

morille commented May 12, 2020

Indeed this issue is resolved, thanks.

@morille morille closed this as completed May 12, 2020
@hayd
Copy link
Contributor

hayd commented May 12, 2020

@brianleroux can you create an issue for aws-sdk issue you faced? I thought, when I'd tried to use it previously, the issue was with missing XML apis.

(It would be amazing if aws-sdk worked ootb...)

@brianleroux
Copy link

since its resolved whats the point ;)

@brianleroux
Copy link

sorry I couldn't resist. this community, like most new communities, needs to work on its manners. or some new individuals do anyhow.

#5249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants