Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: write docs for Web APIs #4325

Closed
bartlomieju opened this issue Mar 12, 2020 · 24 comments
Closed

docs: write docs for Web APIs #4325

bartlomieju opened this issue Mar 12, 2020 · 24 comments
Labels
docs good first issue Good for newcomers

Comments

@bartlomieju
Copy link
Member

Deno strives to be browser compatible where possible; that means we use quite a few Web APIs.

There is not much docs for supported Web APIs at the moment and before 1.0 is released that situation must change. Some of APIs and not fully aligned to spec, while others are not fully implemented (#3557). All that knowledge should be written down and presented to end users to avoid multiple questions/bug reports about purposeful incompatibilities and/or missing implementations.

@kitsonk
Copy link
Contributor

kitsonk commented Mar 12, 2020

The manual is getting a bit heavy/complex. Should we identify first a structure of documents/pages that we would want to cover?

lib.deno.shared_globals.d.ts and lib.deno.window.d.ts provide available Web APIs that are not part of ECMAScript that Deno currently supports.

@bartlomieju
Copy link
Member Author

The manual is getting a bit heavy/complex. Should we identify first a structure of documents/pages that we would want to cover. lib.deno.shared_globals.d.ts and lib.deno.window.d.ts provide available Web APIs that are not part of ECMAScript that Deno currently supports.

I strongly agree on manual, but I'd prefer to get ball rolling on this subject. We're definitely gonna put more effort into restructuring docs after API freeze in the end of April. For now I think it's fine to extend manual.

@ematipico
Copy link

Hi there! I'd like to to take a stab to this issue, as it is marked as good first issue.

What should I do to help and how?

@bartlomieju
Copy link
Member Author

@ematipico thanks! The very first thing would be to extend cli/js/web/README.md with a list of all supported Web APIs (so all APIs in cli/js/web/ that are exposed globally).

@ondras
Copy link
Contributor

ondras commented Mar 31, 2020

@ematipico are you still working on this? I can start doing this if you do not have time.

@ematipico
Copy link

Hi @ondras, yeah feel free to go ahead! I got a mix up with my plans and I don't have much time now. Thank you and sorry!

@ondras
Copy link
Contributor

ondras commented Mar 31, 2020

@ematipico thanks! The very first thing would be to extend cli/js/web/README.md with a list of all supported Web APIs (so all APIs in cli/js/web/ that are exposed globally).

@bartlomieju would something like https://github.com/ondras/deno/blob/web-docs/cli/js/web/README.md make sense to you? What would be next?

I am somewhat unsure about the streams/ subdirectory that contains quite a bit of a Streams implementation, but most of it seems to be commented out. Looks like a WIP, so probably not ready for public documentation.

@bartlomieju
Copy link
Member Author

@ondras yeah that looks good! Next step would be to expand description for each API with its caveats (if there are any, eg. Worker doesn't support structured clone right now).

I am somewhat unsure about the streams/ subdirectory that contains quite a bit of a Streams implementation, but most of it seems to be commented out. Looks like a WIP, so probably not ready for public documentation.

That's correct, streams can be skipped for now.

@ondras
Copy link
Contributor

ondras commented Apr 1, 2020

Next step would be to expand description for each API with its caveats (if there are any, eg. Worker doesn't support structured clone right now).

Great! May I publish the change now? I am afraid I cannot reliably describe individual caveats related to the implementation, as I am not the author of these modules. Will try to add some rudimentary description of what the stuff does, though.

@ondras
Copy link
Contributor

ondras commented Apr 2, 2020

@ondras yeah that looks good! Next step would be to expand description for each API with its caveats (if there are any, eg. Worker doesn't support structured clone right now).

@bartlomieju I pushed another update with some rudimentary description texts and implementation notes for some APIs.

@bartlomieju
Copy link
Member Author

@ondras feel free to open a PR, we can iterate there

@ondras ondras mentioned this issue Apr 2, 2020
@ondras
Copy link
Contributor

ondras commented Apr 2, 2020

Great, opened #4578.

@euanmat
Copy link

euanmat commented Apr 25, 2020

Hello, help wanted ?

Can I help in some way ?

@cknight
Copy link
Contributor

cknight commented May 2, 2020

Looks like streams could be added now? Assuming @kitsonk is finished?

@kitsonk
Copy link
Contributor

kitsonk commented May 3, 2020

the TranformStream is still waiting to be merged

@douglaschalegre
Copy link

Hello! There still is something to be added to Web APIs docs? i would like to help if needed

@ktfth
Copy link
Contributor

ktfth commented May 20, 2020

I can help too on that issue, what have to be done?

@keshav-bohr
Copy link

Would like to help. Let us know

@gungunfebrianza
Copy link

I really want to help also, let us know :) i was playing with Performance API last time :)

@holasoymalva
Copy link

I would really like to contribute, How can I support ?

@ry ry removed the help wanted label Aug 3, 2020
@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2021
@waldyrious
Copy link
Contributor

Looks like there's some overlap between runtime/js/README.md and docs/runtime/web_platform_apis.md. It may be worth at least adding a link from that README to the docs page, so content duplication and possible divergence can be avoided.

@stale stale bot removed the stale label Jan 6, 2021
@LukasDoesDev
Copy link

While playing around with Deno Deploy I noticed that BroadcastChannel does not have proper documentation at doc.deno.land. I also saw that this issue is marked as a good first issue so how can I help?

@bartlomieju
Copy link
Member Author

I'm going to close this issue now as Web APIs supported by Deno are now listed in MDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests