Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same execution environment for REPL #5504

Closed
buckle2000 opened this issue May 16, 2020 · 3 comments · Fixed by #5565
Closed

Use the same execution environment for REPL #5504

buckle2000 opened this issue May 16, 2020 · 3 comments · Fixed by #5565
Labels
bug Something isn't working correctly cli related to cli/ dir repl related to the Read-Eval-Print-Loop functionality of Deno

Comments

@buckle2000
Copy link
Contributor

buckle2000 commented May 16, 2020 •
edited
Loading

Currently, the following code will run without error in deno REPL but will error out as a script:

# a.js
let a = {}
Object.preventExtensions(a)
a.c = 1

This shouldn't be the case.
@kitsonk
Copy link
Contributor

kitsonk commented May 16, 2020 •
edited
Loading

Yeah, forgot REPL was evaluated as a script. Fix should be easy. (Which I will do right now)

@buckle2000 buckle2000 changed the title Use strict mode for REPL Use the same execution environment for REPL May 17, 2020
@buckle2000
Copy link
Contributor Author

buckle2000 commented May 17, 2020 •
edited
Loading

I can't use top level await in REPL too.

@kitsonk
Copy link
Contributor

kitsonk commented May 17, 2020

@buckle2000 that is #3700.

@kitsonk kitsonk mentioned this issue May 17, 2020
Merged
@bartlomieju bartlomieju added bug Something isn't working correctly cli related to cli/ dir repl related to the Read-Eval-Print-Loop functionality of Deno labels May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly cli related to cli/ dir repl related to the Read-Eval-Print-Loop functionality of Deno
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REPL evaluates in strict mode kitsonk/deno
3 participants
@kitsonk @buckle2000 @bartlomieju