Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch_minimal should use promise table from Deno.core #8173

Closed
bartlomieju opened this issue Oct 28, 2020 · 2 comments · Fixed by #9457
Closed

dispatch_minimal should use promise table from Deno.core #8173

bartlomieju opened this issue Oct 28, 2020 · 2 comments · Fixed by #9457
Assignees
Labels
deno_core Changes in "deno_core" crate are needed feat new feature (which has been agreed to/accepted) refactor

Comments

@bartlomieju
Copy link
Member

Currently we have two different dispatch mechanism implemented:

  • minimal - used for io ops (op_read and op_write)
  • JSON - used for all other ops

Each of these mechanism has separate promise table that is used to store promises awaiting response from Rust.

Duplication should be removed and only promise table should be managed by Deno.core namespace.

@bartlomieju bartlomieju self-assigned this Oct 28, 2020
@bartlomieju bartlomieju added the deno_core Changes in "deno_core" crate are needed label Oct 28, 2020
@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Mar 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 14, 2021
@ry ry removed the stale label Mar 14, 2021
@kitsonk kitsonk added the feat new feature (which has been agreed to/accepted) label Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno_core Changes in "deno_core" crate are needed feat new feature (which has been agreed to/accepted) refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants