Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include language service completions in repl completions #8652

Closed
caspervonb opened this issue Dec 7, 2020 · 2 comments
Closed

Include language service completions in repl completions #8652

caspervonb opened this issue Dec 7, 2020 · 2 comments
Assignees
@dsherret
Labels
repl related to the Read-Eval-Print-Loop functionality of Deno suggestion suggestions for new features (yet to be agreed)

Comments

@caspervonb
Copy link
Contributor

LSP has more static knowledge than the runtime does, but the inspector has knowledge of runtime properties so merging the two as the completion source is probably the best of both worlds.
@kitsonk kitsonk added debugger Chrome DevTools inspector/debugger integration lsp related to the language server suggestion suggestions for new features (yet to be agreed) labels Dec 7, 2020
@dsherret dsherret changed the title Include lsp completions in repl completions Include language service completions in repl completions Jun 22, 2021
@dsherret dsherret removed the lsp related to the language server label Jun 22, 2021
@dsherret
Copy link
Member

dsherret commented Jun 22, 2021 •
edited
Loading

If this is implemented it can be done without the language server and instead use the language service. It can be constructed using the compiler API then the getCompletionsAtPosition method would be useful.

@dsherret dsherret added the repl related to the Read-Eval-Print-Loop functionality of Deno label Jun 22, 2021
@dsherret dsherret mentioned this issue Jun 22, 2021
Closed
@bartlomieju bartlomieju removed the debugger Chrome DevTools inspector/debugger integration label Dec 27, 2021
@bartlomieju
Copy link
Member

This has actually been implemented some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
repl related to the Read-Eval-Print-Loop functionality of Deno suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@caspervonb @kitsonk @dsherret @bartlomieju