fix(ci): fix windows ci #9261

kt3k · 2021-01-25T06:10:41Z

An alternative to #9254

This PR tries to avoid windows CI error by passing --py2 option to wpt util script. ref: https://github.com/web-platform-tests/wpt/blob/61d85c8/wpt#L10

ry · 2021-01-25T12:23:51Z

cli/tests/integration_tests.rs

-    }
-  }
+  // Give the wpt runner time to start up.
+  std::thread::sleep(std::time::Duration::from_secs(5));


kt3k · 2021-01-25T12:24:58Z

cli/tests/integration_tests.rs

@@ -5316,39 +5313,8 @@ fn web_platform_tests() {
    .spawn()
    .unwrap();

-  let stderr = proc.stderr.as_mut().unwrap();
-  let mut stderr = BufReader::new(stderr).lines();


We should remove use declaration of this as well?

ry · 2021-01-25T12:26:02Z

cli/tests/integration_tests.rs

    _ => "python3",
  };

  eprintln!("If the wpt server fails or gets stuck, please set up your /etc/hosts file like specified in //docs/contributing/building_from_source.md.");
+  eprintln!("On windows python.exe needs to available in your path, and needs to point to python 3. On macOS and Linux, python3 needs to be available in your path.");


Maybe we should check this here in Rust? Like start python.exe --version and see that it has the correct output?

Would it be ok if I do this when I move the WPT runner to TS?

Not convinced about moving WPT runner to TS, but sure

bartlomieju · 2021-01-25T14:10:32Z

There are some clippy warnings popping up:

warning: unused import: `std::io::BufReader`
 --> cli/tests/integration_tests.rs:8:5
  |
8 | use std::io::BufReader;
  |     ^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: variable does not need to be mutable
    --> cli/tests/integration_tests.rs:5308:7
     |
5308 |   let mut proc = Command::new(python)
     |       ----^^^^
     |       |
     |       help: remove this `mut`
     |
     = note: `#[warn(unused_mut)]` on by default

warning: 2 warnings emitted

lucacasonato · 2021-01-25T15:03:14Z

I have reverted #9046 because I am going to do a full rewrite of the WPT runner. Because of this, this does not apply anymore.

kt3k and others added 4 commits January 25, 2021 15:07

fix: fix windows ci

27b2ca9

fix(test): use py2 for wpt serve

05f3908

run ci again

477c8ef

python3?

b25db11

lucacasonato mentioned this pull request Jan 25, 2021

fix windows ci #9254

Closed

ry reviewed Jan 25, 2021

View reviewed changes

cli/tests/integration_tests.rs

}

}

// Give the wpt runner time to start up.

std::thread::sleep(std::time::Duration::from_secs(5));

Copy link

Member

ry Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

kt3k commented Jan 25, 2021

View reviewed changes

ry reviewed Jan 25, 2021

View reviewed changes

lucacasonato closed this Jan 25, 2021

kt3k deleted the fix/win-wpt-script branch March 1, 2022 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): fix windows ci #9261

fix(ci): fix windows ci #9261

kt3k commented Jan 25, 2021 •

edited

Loading

ry Jan 25, 2021

kt3k Jan 25, 2021

ry Jan 25, 2021

lucacasonato Jan 25, 2021

ry Jan 25, 2021

bartlomieju commented Jan 25, 2021

lucacasonato commented Jan 25, 2021

fix(ci): fix windows ci #9261

fix(ci): fix windows ci #9261

Conversation

kt3k commented Jan 25, 2021 • edited Loading

ry Jan 25, 2021

Choose a reason for hiding this comment

kt3k Jan 25, 2021

Choose a reason for hiding this comment

ry Jan 25, 2021

Choose a reason for hiding this comment

lucacasonato Jan 25, 2021

Choose a reason for hiding this comment

ry Jan 25, 2021

Choose a reason for hiding this comment

bartlomieju commented Jan 25, 2021

lucacasonato commented Jan 25, 2021

kt3k commented Jan 25, 2021 •

edited

Loading