Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic when someone uses a wildcard in an export #134

Open
dsherret opened this issue Nov 4, 2024 · 1 comment
Open

Diagnostic when someone uses a wildcard in an export #134

dsherret opened this issue Nov 4, 2024 · 1 comment

Comments

@dsherret
Copy link
Member

dsherret commented Nov 4, 2024

denoland/deno#26693

@satyarohith
Copy link
Member

satyarohith commented Nov 4, 2024

Shouldn't this be an error instead of a diagnostic similar to

if key.is_empty() {
bail!(
"The {} must not be empty. Use '.' if you meant the root export.",
key_display()
);
}

?

Edit: there is already an error that is generated for unexpected characters:

run_test(
r#"{ "exports": { "./mod*": "./mod.ts" } }"#,
"The './mod*' export must only contain alphanumeric characters, underscores (_), dashes (-), dots (.), and slashes (/).",
);

@satyarohith satyarohith removed their assignment Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants