Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public JS Error classes should accept the options argument #1031

Closed
kt3k opened this issue Jan 6, 2025 · 0 comments · Fixed by #1042
Closed

Public JS Error classes should accept the options argument #1031

kt3k opened this issue Jan 6, 2025 · 0 comments · Fixed by #1042

Comments

@kt3k
Copy link
Member

kt3k commented Jan 6, 2025

Currently public error classes (BadResource, Interrupted, and NotCapable) do not accept the 2nd argument. That is inconvenient when the downstream implementation want to use, for example, cause option of Error class (See https://github.com/denoland/deno/pull/27463/files#diff-847a11c353dfb7aeae6e35bc104b83a091ef797bdfc559d22ccfc804a3615000R380 for example)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support options in error constructors kt3k/deno_core
1 participant
@kt3k