Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eszip extract fails when a specifier in the eszip has no path or is a directory of another specifier #101

Open
dsherret opened this issue Dec 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dsherret
Copy link
Member

The code here:

await write(join(dest, "source", url2path(specifier)), module);

...is very basic and looks at the pathname only to figure out how to extract.

This will fail in two scenarios:

  1. Where there is no path, like https://fresh.deno.dev
  2. A path is a directory of another specifier. For exmaple: something/ then something/other.ts
@dsherret dsherret added the bug Something isn't working label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant