Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing Deno.ServeTlsOptions type removed in Deno 2.0.0 #2713

Open
5t111111 opened this issue Oct 16, 2024 · 0 comments
Open

Referencing Deno.ServeTlsOptions type removed in Deno 2.0.0 #2713

5t111111 opened this issue Oct 16, 2024 · 0 comments

Comments

@5t111111
Copy link

5t111111 commented Oct 16, 2024

It seems that Deno.ServeTlsOptions has been removed in Deno 2.0.0, but there are places in Fresh where this type is still being used.

server?: Partial<Deno.ServeTlsOptions>;

server: Partial<Deno.ServeTlsOptions>;

Additionally, there are parts of the documentation that still reference it: https://fresh.deno.dev/docs/concepts/server-configuration

It appears that these references remain in the 1.x branch, but they are no longer used in the main branch.

This doesn't seem to cause any issues where Fresh applications fail to start due to type errors, and if Fresh v2.0 is going to be released soon, it might be fine to leave it as is. However, it also seems possible to hard-code a type with the same interface without relying on a version-incompatible type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant