You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I know, string in C++ is not required to be utf8 only. Therefore, the function source_url might incorrectly assume that the string should also be legal in Rust.
Hi, I am wondering whether this code might create an illegal string, which contains any non-utf8 value.
rusty_v8/src/wasm.rs
Lines 158 to 164 in 6b12ea1
Based on the pointer passed by
v8__CompiledWasmModule__SourceUrl
rusty_v8/src/binding.cc
Lines 3737 to 3741 in 6b12ea1
As I know, string in C++ is not required to be utf8 only. Therefore, the function
source_url
might incorrectly assume that the string should also be legal in Rust.refer to the documentation (https://v8.github.io/api/head/classv8_1_1CompiledWasmModule.html), there is also no guarantee of utf8 encoding in the definition.
The text was updated successfully, but these errors were encountered: