Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable flags not respected when running tests #1161

Closed
kitsonk opened this issue Sep 10, 2024 · 1 comment · Fixed by denoland/deno#25552
Closed

Unstable flags not respected when running tests #1161

kitsonk opened this issue Sep 10, 2024 · 1 comment · Fixed by denoland/deno#25552

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Sep 10, 2024

Describe the bug

While #1159 provides the ability to specify granular unstable flags, those flags are not respected when running tests within the IDE, and tests requiring unstable flags no longer run in the IDE with Deno 2.0.

Also the README still indicates that the value of deno.unstable is a boolean.

To Reproduce

  1. create a test that requires Deno.KV
  2. configure the configuration like "deno.unstable": ["kv"]
  3. Execute the test in the IDE
  4. Review output of the Deno Language Server and observe:
Executing test run with arguments: deno test --allow-all --no-check --trace-leaks --unstable

Expected behavior

The test executes successfully.

Versions

vscode: 1.93.0 deno: 2.0.0-rc.1 extension: 3.40.0

@nayeemrmn
Copy link
Collaborator

It will only work with 2.0.0-rc.2 released tomorrow, to not break the server's expected config for earlier versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants