Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension commands do not work until js/ts file has been opened #334

Closed
lucacasonato opened this issue Feb 19, 2021 · 1 comment · Fixed by #336
Closed

Extension commands do not work until js/ts file has been opened #334

lucacasonato opened this issue Feb 19, 2021 · 1 comment · Fixed by #336
Assignees
Labels
bug Something isn't working

Comments

@lucacasonato
Copy link
Member

Describe the bug

The VS Code actions on the command palette provided by this extension do not work (error out) until the user has opened a JS/TS file in the workspace.

To Reproduce

  1. Open a VS Code workspace with the extension disabled (no files open)
  2. Open command palette and run Deno: Welcome
  3. See this error: Command 'Deno: Welcome' resulted in an error (command 'deno.welcome' not found)

Expected behavior

The Deno: Welcome and Deno: Initialize Workspace Configuration options should always work, and all other commands should only be present in the command palette if the lsp has been started and is ready to receive commands.

Versions

vscode: 1.53.2
deno: deno 1.7.4
extension: 3.0.1

@lucacasonato lucacasonato added the bug Something isn't working label Feb 19, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Feb 19, 2021

I will check if there is a way to activate the extension in more general scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants