Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does anyone think it's better to set the default value of deno.enable to false #70

Closed
lovefengruoqing opened this issue May 30, 2020 · 4 comments

Comments

@lovefengruoqing
Copy link

First of all, thank you for writing such a great plugin。When I wrote deno, it helped me a lot

But most of my projects are nodejs or pure front-end projects. When I use vscode to open these projects, I need to set the deno.enable property in the settings.json file. Otherwise, vscode will give a lot of warnings.

I feel a little annoyed. Because I don't want to create the settings.json file in some projects. If I forget to ignore the file in .gitignore, I may accidentally upload this file to the remote repository. This may confuse my partners.

Why not consider setting the default value of deno.enable to false?

@TTSKarlsson
Copy link

You can set deno.enable to false in your global settings, and set it to true in the project settings for your deno projects.

@lovefengruoqing
Copy link
Author

You can set deno.enable to false in your global settings, and set it to true in the project settings for your deno projects.

Thank you, you are right. I forgot to set it like this.

However, I feel that it should be more friendly if the default setting is false.

When I first encountered this problem, I did not study the plugin in detail. I thought it was a problem with the project code. I even regarded it as a bug of vscode.

@TTSKarlsson
Copy link

I agree, but somehow I believe that when this extension/plugin gains a way to decide what's deno on a per folder basis or something similiar (include glob in tsconfig maybe), this problem also goes away. And from reading the issues, this is already in the pipe. (#39)

@garysb
Copy link

garysb commented Jun 7, 2020

Please also see issue #75 related to this. It seems to be a common request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants