Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command for deno disable #816

Closed
cojmeister opened this issue Mar 1, 2023 · 6 comments · Fixed by #1010
Closed

Add a command for deno disable #816

cojmeister opened this issue Mar 1, 2023 · 6 comments · Fixed by #1010
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cojmeister
Copy link

Just add a command palette command that allows to disable deno linting.

The current solution is to manually make a .vscode/settings.json file and set "deno.enable": false

@bartlomieju bartlomieju added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 10, 2023
@You-saku
Copy link

This Issue sounds interesting. I'd like to work on resolving this issue as my first contribution.

I'm not sure if I can achieve it, but I want to try.

@nayeemrmn
Copy link
Collaborator

@You-saku Thanks! A similar command is registered here:

registerCommand(
"deno.client.initializeWorkspace",
commands.initializeWorkspace,
);

export function initializeWorkspace(
_context: vscode.ExtensionContext,
_extensionContext: DenoExtensionContext,
): Callback {
return async () => {
try {
const settings = await pickInitWorkspace();
const config = vscode.workspace.getConfiguration(EXTENSION_NS);
await config.update("enable", true);

@jsejcksn
Copy link
Contributor

Just a note: This functionality previously existed and was removed. Ref: #170

@You-saku
Copy link

Thanks. I saw the past issue and discussion. I thought it wasn't enough to add it as a command too.

So, This issue close ?

@jsejcksn
Copy link
Contributor

jsejcksn commented Dec 12, 2023

Thanks. I saw the past issue and discussion. I thought it wasn't enough to add it as a command too.

So, This issue close ?

Given the extension's current default behavior, I think it is very useful for a "disable" command to exist again.

@bartlomieju
Copy link
Member

@nayeemrmn this seems reasonable. Could you add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants