Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recusrive submods #217

Merged
merged 4 commits into from
Apr 22, 2022
Merged

fix recusrive submods #217

merged 4 commits into from
Apr 22, 2022

Conversation

tnichols217
Copy link
Contributor

Fix Issue #216

Copy link
Owner

@Vinzent03 Vinzent03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain your changes? I left already 2 basic comments.

src/simpleGit.ts Outdated Show resolved Hide resolved
src/simpleGit.ts Outdated Show resolved Hide resolved
@tnichols217
Copy link
Contributor Author

tnichols217 commented Apr 11, 2022

All i do is switch the command from git submodule --recursive foreach to just git submodule --recursive in order to parse the stdout to get the list of submodules, which i then parse to get just the directory, enter those directories and commit and push. Because when you run git submodule --recursive foreach it runs from highest directory to lowest, which is the incorrect way of committing changes to recursive submodules, so i reversed the list of submodules before committing, the bug that effected this plugin.

@tnichols217 tnichols217 requested a review from Vinzent03 April 12, 2022 05:40
@Vinzent03
Copy link
Owner

@tnichols217 Okay thanks for the explanation. Can you please choose some proper variable names instead of x,y,z,m,l? It's hard to read.

@tnichols217
Copy link
Contributor Author

@tnichols217 Okay thanks for the explanation. Can you please choose some proper variable names instead of x,y,z,m,l? It's hard to read.

Apologies, it's a habit from competitive programming. I'll change that now.

@tnichols217
Copy link
Contributor Author

tnichols217 commented Apr 13, 2022

Done! Hows this? @Vinzent03

@Vinzent03
Copy link
Owner

Hey I just added my own changes. I tried to properly await the commits inside the handler and some styles. Could you please verify that it's still working on your end?

@tnichols217
Copy link
Contributor Author

Hey I just added my own changes. I tried to properly await the commits inside the handler and some styles. Could you please verify that it's still working on your end?

Just tested, working perfect. Thanks for the feedback!

@Vinzent03 Vinzent03 merged commit 98f566f into Vinzent03:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants