Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Source control view icon is overridden when pinned #252

Closed
NomarCub opened this issue Jun 28, 2022 · 2 comments
Closed

[Bug]: Source control view icon is overridden when pinned #252

NomarCub opened this issue Jun 28, 2022 · 2 comments

Comments

@NomarCub
Copy link

Describe the bug

With the new insider release, the panes made by the plugin have their icon overridden when pinned. Also, If I have the source control view in the sidebar and don't pin it, I get stuck in the diff view if I click on a file change, so pinning becomes necessary.

Relevant errors (if available)

No response

Steps to reproduce

Open source control view, pin the pane in the sidebar.

Expected Behavior

No response

Addition context

No response

Operating system

Windows

Plugin version

1.26.1

@peterkaminski
Copy link

I'm running Obsidian v0.15.6 and Obsidian Git v1.26.1 on MacOS, and I couldn't figure out how to get out of diff view.

Pinning the pane forces diff view to open in another pane, while the Source Control View stays open, and then it's easy to close the diff pane when I'm done with it. So pinning is necessary to be able to get back to Source Control View.

And as OP notes, the Source Control View icon at the top is overridden by the pin icon.

@Vinzent03
Copy link
Owner

I think overriding the icon is an Obsidian issue, because the same happens to Obsidian's own sidebar panes like "Backlinks".

You are correct that since Obsidian v0.15 the diff view gets opened in the sidebar. Will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants