Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Diff view is broken on mobile #302

Closed
NomarCub opened this issue Sep 7, 2022 · 4 comments
Closed

[Bug]: Diff view is broken on mobile #302

NomarCub opened this issue Sep 7, 2022 · 4 comments

Comments

@NomarCub
Copy link

NomarCub commented Sep 7, 2022

Describe the bug

The diff view comes up empty, and when you open a file from file navigation or quick switcher it opens besides the diff view, not instead/on top of it as I'd expect for a view on mobile.

Screenshot_2022-09-07-17-08-09-89_51606159b24eff83e24a54116878fe3e

Relevant errors (if available)

No response

Steps to reproduce

Open a changed file in diff view. Opan a file from quick switcher.

Expected Behavior

No response

Addition context

No response

Operating system

Android

Plugin version

2.0.3

@NomarCub
Copy link
Author

In 2.1.1 the split is fixed, but the diff view is still empty.

@Vinzent03
Copy link
Owner

The underlying lib doesn't provide a diff method so I have to get the diff with a different lib and format it like the git output.

@NomarCub
Copy link
Author

I'm fine with whatever solution.
It should be mentioned here at least: https://github.com/denolehov/obsidian-git#restrictions-of-the-mobile-version
And the command should be disabled if it's not done.

@Vinzent03
Copy link
Owner

You are right, but I already started working on this and will hopefully be finished soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants