Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Diff View to open & focus new tab if current tab pinned #377

Closed
huyz opened this issue Nov 16, 2022 · 4 comments
Closed

[FR] Diff View to open & focus new tab if current tab pinned #377

huyz opened this issue Nov 16, 2022 · 4 comments

Comments

@huyz
Copy link

huyz commented Nov 16, 2022

When I open "Diff View" via command palette or shortcut, the behavior is a bit inconsistent.
On a regular tab, the diff view opens in the current tab.
If the tab is pinned, then the diff view opens in the first non-pinned tab it can find (and doesn't focus the view).

It would be nice if when the current tab is pinned, the "Diff View" opened in a brand new tab and changed focus to it.

@Vinzent03
Copy link
Owner

I'm using the default Obsidian behavior with reusing an existing tab, when the current tab is pinned. So I won't change that for now. But I fixed the focus when using the command instead of the source control view.

@huyz
Copy link
Author

huyz commented Nov 18, 2022

Cool, thanks.

I will point out that the default Obsidian behavior is not good either (they do make a lot of UX mistakes). I will file a FR with core Obsidian for that.

@huyz
Copy link
Author

huyz commented Nov 18, 2022

I posted a FR for core: https://forum.obsidian.md/t/click-on-an-internal-link-in-a-pinned-note-should-open-a-brand-new-tab/47895

At least with core, I have a workaround: ⌘Click. No such thing with Diff view, unless a special command is added.

@Vinzent03
Copy link
Owner

You can use ctrl click in the source control view. At the moment, I don't plan to add an extra command for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants