Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing multithreading lock on Source Control buttons #517

Closed
ddelange opened this issue May 26, 2023 · 1 comment
Closed

[Bug]: Missing multithreading lock on Source Control buttons #517

ddelange opened this issue May 26, 2023 · 1 comment

Comments

@ddelange
Copy link

ddelange commented May 26, 2023

Describe the bug

If I press the Backup (leftmost) button in source control (especially on mobile where it's a bit slower), and I press it again 1 second later, there will be duplicate notifications. Two pulls, two commits, etc running concurrently. I was now left with a broken branch on mobile, because the commit referenced an object that only existed because there was another thread that was writing git objects.

Relevant errors (if available)

`NotFoundError: could not find ab42cd42...`

Steps to reproduce

Run Backup twice in short succession on mobile.

Expected Behavior

When any of the actions is currently running (wheel is spinning in source control), I expect all the buttons to be grayed out. It should only release / make the buttons clickable again, once the last action has finished.

Addition context

From the command palette options, I see no way to correct here. I would like a git reset --hard origin/master, now I'm resorting to copying my desktop .git to my phone.

Operating system

Android

Installation Method

Other

Plugin version

2.20.0

@Vinzent03
Copy link
Owner

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants