Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull failed warning #61

Closed
drozzy opened this issue Apr 2, 2021 · 14 comments
Closed

Pull failed warning #61

drozzy opened this issue Apr 2, 2021 · 14 comments

Comments

@drozzy
Copy link

drozzy commented Apr 2, 2021

Setting both push and pull time to 1 minute I still get this occasionally (but nothing breaks):
Screenshot from 2021-04-02 19-35-38

@drozzy drozzy changed the title Pull error Pull failed warning Apr 2, 2021
@Vinzent03
Copy link
Owner

Vinzent03 commented Apr 2, 2021

Are you on the latest version? (1.8.0)

@drozzy
Copy link
Author

drozzy commented Apr 3, 2021

Yeah, I just installed it today.
It's odd it happens occasionally. Maybe it has something to do with pull&push and pull happening at the same time?

@Vinzent03
Copy link
Owner

Vinzent03 commented Apr 3, 2021

What is the output of git status in the terminal? (Open terminal in your vault root)

@drozzy
Copy link
Author

drozzy commented Apr 4, 2021

It's all clean. So clearly the pull/add/commit/push happens successfully.

@Vinzent03
Copy link
Owner

I have no problems with setting both pull and push to one minute. Now I get it. That's a normal git error message. You called pull, which was not able to merge fast-forward your changes, why git wants you to commit your changes. That happened, because the pushcommand was called directly afterwards. That's no error with this plugin,
In generally you cannot pull when pulled files are not committed in your working directory.

@drozzy
Copy link
Author

drozzy commented Apr 4, 2021

Um... I didn't call anything manually. My repo is pushed.
But that's not even the issue for me. It's the pop up that's annoying.

The plug-in still shows this error as a pop up even though I disabled notifications. It would be nice to disable this notification as well.

@Vinzent03
Copy link
Owner

The issue does still occur? Could you run git pull manually from the terminal? Does it work without error?

This notification is handled as an error and not as an information, why the notifications is still shown.

@Vinzent03 Vinzent03 reopened this Apr 4, 2021
@denolehov
Copy link
Collaborator

@drozzy please make sure that your files are backed up by other means rather than via git, and run git reset --hard and then git pull from the command line. Making your repository "clean" should resolve this issue.

@drozzy
Copy link
Author

drozzy commented Apr 6, 2021

Yes, I ensured that my git pull is clean and I did git reset --hard as well. I am certain my repository is clean. Yet it still happens.

I observed that this happens if I am typing something continuously, and the "obsidian git" plugin is triggered in the middle of me typing.

@a-trost
Copy link

a-trost commented Apr 12, 2021

Getting this same exact error every time my auto-pull triggers. Already did git reset --hard and git pull, it's all good except for that error getting thrown. On the latest version.

I'm also seeing that it seems to happen if it triggers when I'm typing.

Also I agree with this:

The plug-in still shows this error as a pop up even though I disabled notifications. It would be nice to disable this notification as well.

Let me know if there's anything I can do to help with this.

@Vinzent03
Copy link
Owner

Do you have only auto pull enabled or auto push too? And the remote repo had no changes since the last push from Obsidian? Because I think this error can just be related to changes from the remote.

@a-trost
Copy link

a-trost commented Apr 12, 2021

Hey @Vinzent03 I have both enabled at 3 minute intervals.
Here are my settings:
image

Nothing changed on the remote repo.
I'm guessing there's something weird with the combination of Push+Pull happening at the same time plus the "Pull changes before push" firing all at once. Just a hunch though.

@Vinzent03
Copy link
Owner

I can reproduce. Working on it now.

@Vinzent03
Copy link
Owner

I hope the new release fixes the issue. Added a promise queue so that the commands are not executed simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants