Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Conflicts since #68 was fixed. #74

Closed
despairblue opened this issue May 12, 2021 · 7 comments
Closed

Merge Conflicts since #68 was fixed. #74

despairblue opened this issue May 12, 2021 · 7 comments

Comments

@despairblue
Copy link

Hey, first of, thanks for creating this extension. I don't use a lot of community plugins, but this one turned out to be indispensable. Great work 👏🏾

Adding the timestamp in the data.json file leads to merge conflicts if obsidian is used on multiple machines and obsidian-git is used to synchronize the vault:

image

Every obsidian instance will updated the timestamp before pulling and thus create a conflict in that file. It's not that this sometimes happens, it happen consistently every time.

I wonder if

  • that timestamp could be in a different file that could be added to .gitignore or
  • if the timestamp could turned off or
  • if the timestamp could only be updated right after a pull

I think all of those would fix this. What do you thing would be the best option?

@RichSteele
Copy link

I can confirm I've been seeing this behavior as well. Thank you for finding the probable cause of an issue I haven't had a chance to track down yet.

@Vinzent03
Copy link
Owner

Vinzent03 commented May 12, 2021

I totally see your point. Will decide me for a solution today and patch a fix. Haven't thought about that.

@Vinzent03
Copy link
Owner

Vinzent03 commented May 12, 2021

Should be fixed now. Let me know if you have further problems.
I am saving the information now in an additional file. Please add it to your .gitignore
Thanks for your detailed description!
Fixed another bug too. 😅

@despairblue
Copy link
Author

Is there a way to try this directly from git as the fix is not released yet?

@Vinzent03
Copy link
Owner

Sorry I just totally forgot that. Will do it now!

@Vinzent03
Copy link
Owner

New release is out

@despairblue
Copy link
Author

Thank you, this fixed it 👏🏾

@Vinzent03 Vinzent03 mentioned this issue Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants