Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Commits #90

Closed
dotkiddo opened this issue Jul 12, 2021 · 2 comments
Closed

Empty Commits #90

dotkiddo opened this issue Jul 12, 2021 · 2 comments

Comments

@dotkiddo
Copy link

Please remove "empty" commits.

Expected Behaviour:

If there are no user-generated changes to commit, no commit should be made.

Result:

A clean git tree only showing user-generated content updates.

Current Behaviour:

A commit is made every vault backup interval minutes whether there are any user-generated changes to commit or not.

Result:

A quickly growing git tree bloated with only lastAutoBackUp changed changes
(by now > 3k commits in my git history and counting, many of these don't have any user-generated changes):

image

@Vinzent03
Copy link
Owner

Vinzent03 commented Jul 12, 2021

Related to #78 . Will fix it this evening by storing this information in localStorage.
EDIT:
But wait... Are you on the latest version? It shouldn't get stored in data.json. There is an extra file #74

@dotkiddo
Copy link
Author

dotkiddo commented Jul 12, 2021

Thank you for the swift response!! :)

Currently on version 1.9.1
Updating to 1.9.2 now, will update on the behaviour following.

EDIT:

Current behaviour:

Same as described in issue description
However, the file is different: the date of update is set in .obsidian-git-data instead of in data.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants