Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the move from typescript to web assembly #2

Closed
oplik0 opened this issue May 30, 2020 · 3 comments
Closed

Start the move from typescript to web assembly #2

oplik0 opened this issue May 30, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request released

Comments

@oplik0
Copy link
Member

oplik0 commented May 30, 2020

While no good wasm scrypt implementation exists (the only one I found didn't work for me, which is probably caused by it using an older version of rust and wasm-pack. It's also just possible that the fork didn't actually fix the problem that made original incompatible with web assembly), there might be web assembly versions of some of the functions used by scrypt like pbkdf2 or perhaps salsa20 that might be modified to only use core with 8 rounds. So at least partial transition might be possible now, even if full one will have to wait until I or someone else makes something that works.

@oplik0 oplik0 added the enhancement New feature or request label May 30, 2020
@oplik0 oplik0 self-assigned this May 30, 2020
@oplik0 oplik0 closed this as completed in 77993bd Jun 21, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oplik0
Copy link
Member Author

oplik0 commented Jun 21, 2020

Thanks to the work of skdltmxn there is now a nice build script for wasm-pack that works with deno that was used for std/hash wasm implementation.

The performance was improved by A LOT. A quick benchmark with standard parameters changed from ~650ms to ~180ms. I'll try to run some more benchmarks later, but the performance gains are really big.
And it still doesn't need any privileges to run!

@AnandChowdhary
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants