Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 breaks support for Deno versions prior to 1.17 #3

Closed
bennyvdhoogen opened this issue Jun 20, 2022 · 2 comments
Closed

v0.2.0 breaks support for Deno versions prior to 1.17 #3

bennyvdhoogen opened this issue Jun 20, 2022 · 2 comments

Comments

@bennyvdhoogen
Copy link

Not sure how much of a priority backwards compatibility is in Deno land; but recently ran into an issue with this package on a bot that I have running in 'production' on AWS Lambda. I've uploaded the deno runtime binary some time ago and noticed today that it crashes on importing this package due to an unexpected assert statement(emoji.ts:4). I see that import assertions were added in Deno 1.17 and am certain the used runtime binary is from before that.

As Deno is quickly evolving I wouldn't want to advice against using newer features, but perhaps worth mentioning that this is a breaking change in the readme?

Note: in a node stack this would usually mean that the required node version is updated in the package.json. What would the node equivalent of locking a package to a Deno version be? The closing argument on denoland/deno#3155 suggests that authors write some sort of prompt manually?

@bpevs
Copy link
Contributor

bpevs commented Jul 7, 2022

Oh shoot this wasn't an intentional deprecation; side effect of changing all.ts -> all.json.
I had switched to json, because it seemed like a more generic way to store large object blobs.
I didn't realize that import assertion was a new feature. 100% my fault.

I wonder if it's better to mention breaking change somewhere, or better to revert that part of the change to generating a .ts file...

@bpevs
Copy link
Contributor

bpevs commented Jul 7, 2022

Could make change like:
main...bpevs:emoji:json-ts
?

@eliassjogreen eliassjogreen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants