Improve package version detection using jq, python and node

[salmanulfarzy]

grep solution to fetch version package.json was hacky and wasn't always returning expected values. Now using other fallback methods to get version information, Following discussions from #439

Changes

• Fetch version information with jq with fallback to python and node.
• Gracefully exit from the section if no version information is found or is undefined from package.json

Fix #439
Close #552
Close #553

[salmanulfarzy]

This returns the top level version information from package.json and won't consider version information nested inside othres.

This works,

https://github.com/denysdovhan/spaceship-prompt/blob/08361383e91bc40fb30bdb223377ba796e04dc90/package.json#L1-L4

This won't, (from #552)

---

@Darkhogg It would be better if you leave a comment while down voting things, So we could figure out what we missed and resolve that.

[maximbaz]

The fact that grep solution looks for nested versions is the actual bug, that's why I was saying that there's no place for grep approach in this section.

Here's the full package.json from the picture you shared, this section must have retrieved only parent version: https://github.com/NativeScript/sample-Groceries/blob/master/package.json

[Darkhogg]

@salmanulfarzy I believe using grep as the only fallback is silly, as there are plenty of other ways of getting the version in a correct way (i.e.: parsing JSON) that will work for most people, if not everyone.

I discussed alternatives and my opinion on this topic in #439.

[nfischer]

As a practical suggestion: I think you could avoid some controversy by reverting the grep regex exactly back to what it was before (the user would then need to install jq to fix their bug). That would make this PR strictly better than what's on trunk, although you would have to accept that the jq and grep code paths may differ in behavior.

Or, you could land as-is (or with my suggested regex switch), in which case I still think this is better than the state of master. But this risks breaking other cases.

You could always debate a follow-up PR to swap in node as the fallback option. But please should check spaceship::exists node to be safe.

[salmanulfarzy]

why I was saying that there's no place for grep approach in this section.

using grep as the only fallback is silly, as there are plenty of other ways of getting the version in a correct way (i.e.: parsing JSON) that will work for most people,

Suggestion by @Darkhogg to use python and node as fall backs sounds good. Dropping that in favor of current methods.

Left notes on Options and Troubleshooting page regarding potential performance issues.

this section must have retrieved only parent version: https://github.com/NativeScript/sample-Groceries/blob/master/package.json

New changes works on this file.

[maximbaz]

Awesome 👍

[denysdovhan]

Looks OK for now. I think you can merge it @salmanulfarzy.

However, I have a few doubts about this section overall. This section was built for showing package version, speaking about any package manager and not only npm. Right now it tries to parse JSON (because we know that package.json is JSON). Nevertheless, not every package manager uses JSON, some of them uses YAML, TOML, etc syntax.

I'm thinking about moving this section out of the Spaceship and distribute as an optional third-party section.

[nfischer]

I'm thinking about moving this section out of the Spaceship and distribute as an optional third-party section.

@denysdovhan What's spaceship's API to add in third-party modules? I filed #318 a while back because I felt support was lacking--but let me know if things have changed since then.

[denysdovhan]

Looks better now.

[salmanulfarzy]

Commits are mess in this now, Will merge after fixing that 😄