Skip to content
This repository has been archived by the owner on Mar 5, 2018. It is now read-only.

Calling an embedded Navigator results in a new http request #39

Closed
tspng opened this issue May 4, 2015 · 3 comments
Closed

Calling an embedded Navigator results in a new http request #39

tspng opened this issue May 4, 2015 · 3 comments
Labels
Milestone

Comments

@tspng
Copy link
Contributor

tspng commented May 4, 2015

Hi

I think I discovered a bug but maybe it's the expected behaviour, I'm not sure.

When you call (execute) a Navigator (not orphaned) that was created from an embedded resource, a new http request is being made. Even though the navigator's state is already present.

I'm happy to provide a CR if this is seems to be a bug.

Cheers.

@deontologician
Copy link
Owner

Hi @Haestan,

What are the semantics of the embedded resource? Does it have a self link or not?

If it has a self link, then just doing N() should not send an http request (but N.fetch() should)

If it doesn't have a self link, then N() should not send a request ever (since it has no url of its own).

I'm assuming this is a straightforward bug where it's just ignoring the cached state and sending the request no matter what. If that's the case, then a CR would be great

@deontologician deontologician added this to the 1.1 Release milestone May 4, 2015
@tspng
Copy link
Contributor Author

tspng commented May 5, 2015

Seems to be a bug. Added a new CR #40

@deontologician
Copy link
Owner

Fixed in #40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants