Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't import l10n files #55

Closed
janein opened this issue Apr 24, 2024 · 3 comments · Fixed by #56
Closed

Can't import l10n files #55

janein opened this issue Apr 24, 2024 · 3 comments · Fixed by #56
Labels
type: bug Something isn't working

Comments

@janein
Copy link

janein commented Apr 24, 2024

Hi,

thanks for this awesome, accessible lightbox! :)

I ran into an issue importing the l10n files.
When I try to import them like this:

import de from 'parvus/src/l10n/de';

I get an error in my bundler (= vite):

Missing "./src/l10n/de" specifier in "parvus" package

Looks like there is an error in the package configuration.
I had the same issue with the styles, but I got it working once i moved the import into my scss-files and used an absolute path.

// won't work
@import 'parvus/src/scss/parvus';
// works
@import '/node_modules/parvus/src/scss/parvus';

Would be nice if you could manage to fix this.

Thanks! :)

@deoostfrees deoostfrees added the type: bug Something isn't working label Apr 25, 2024
@deoostfrees
Copy link
Owner

Hi @janein,

I was able to reproduce it and I will fix it quickly.

@deoostfrees deoostfrees linked a pull request Apr 26, 2024 that will close this issue
@deoostfrees
Copy link
Owner

Hi @janein,

language files can now be imported again. Unfortunately, you still need to specify the full path to the sass file. I need to do some more research on this.

@janein
Copy link
Author

janein commented Apr 29, 2024

Thanks a lot for this quick fix! :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants