Ignore on inline comments

[zchee]

Currently, complements even during inline comments.
e.g.

fmt.Printf("|")
//          ^
//          | cursor

I don’t mind either way.
Please let us know what you think.

[mmlb]

Yeah I've noticed this and have found it slightly annoying, it would be nice to not have it.

[Shougo]

Hm...
I can add the feature though.

[zchee]

@Shougo Its meaning is add implements to deoplete?

[Shougo]

neocomplete implements near feature: neocomplete#helper#get_syn_name().

[zchee]

@Shougo Ok, I check it now.

[zchee]

@Shougo I understand.
Is it like this?

e.g. (sloppy...)

let neocomplete.within_comment = neocomplete#helper#get_syn_name(1) =~? '"'

[Shougo]

Yes, but it is slow.
It should be called if it is really needed.

[zchee]

@Shougo Oh...

Tentatively, realized in this. based by #19
In golang, Comments start is // or /*.
It does not supported /* and buggy,
https://gist.github.com/zchee/72e2007991c188030742#file-deoplete-go-py-L48-L49

Is this also slow?

[fatih]

YCM has this option g:ycm_complete_in_comments: https://github.com/Valloric/YouCompleteMe/blob/master/doc/youcompleteme.txt#L1970-L1977

Which is a setting to enable/disable inside comments

And g:ycm_complete_in_strings: https://github.com/Valloric/YouCompleteMe/blob/master/doc/youcompleteme.txt#L1980-L1994

For enabling/disabling inside strings

Would be great if could have it inside deoplete or somehow inside deoplete-go. Not sure which is the correct place.

[Shougo]

Is this also slow?

It is not slow. But it is too hard to parse the comment correctly.
The Vim syntax feature is slow but it is more correctly.

[Shougo]

@fatih I think YCM already implements same feature with neocomplete.
But I think it is slow.

[Shougo]

I have added get_syn_name() in deoplete.util.

[zchee]

@Shougo Thanks!
I'll check later.

It is not slow. But it is too hard to parse the comment correctly.
The Vim syntax feature is slow but it is more correctly.

I understand. sure, it seems difficult...

[Shougo]

I have implemented "disabled_syntaxes" feature.

[zchee]

@Shougo Thanks!!
Fix of the code of deoplete-go is no longer required. You have saved me.

@fatih Your wishes also came true in deoplete.nvim core implementation.

Also, this issue thread has been resolved, Close.