Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Claims request decision job id fix #6007

Closed
5 tasks
aherzberg opened this issue Jun 9, 2023 · 3 comments
Closed
5 tasks

Backend: Claims request decision job id fix #6007

aherzberg opened this issue Jun 9, 2023 · 3 comments
Assignees
Labels
eng Ticket requires engineering work, other labels for specific backend or frontend

Comments

@aherzberg
Copy link
Contributor

Description

the new Lighthouse endpoint returns a boolean success rather than the job id. FE doesn't use the id so for backwards compatibility we're keeping the Job id field and just put string of success or failed for debugging purposes.

Dependent Issue

department-of-veterans-affairs/va-mobile-app#0000 or N/A

Test users

vets.gov.user+000@gmail.com

Acceptance Criteria

  • ...
  • It logs its progression through the 'happy path' or helpful error details.
  • I tested the feature on staging and could demo it if asked.
  • Public Ruby API methods have Yardoc comments.
  • The OpenAPI documentation is up-to-date.
@aherzberg aherzberg added back-end eng Ticket requires engineering work, other labels for specific backend or frontend labels Jun 9, 2023
@aherzberg aherzberg self-assigned this Jun 13, 2023
@TKDickson TKDickson self-assigned this Jun 14, 2023
@TKDickson
Copy link
Contributor

Adding a comment (supplementing the documentation from 6 days ago when I added the blocking ticket) - this ticket is blocked by #6010, which is blocked by an external team's work.

@TKDickson
Copy link
Contributor

Even though it's a larger time sink in terms of data prep (that I will have to repeat after the blockers around #6010 are resolved), I don't have anything else on my list this morning so pulling this out of the blocked column and taking a look.

@TKDickson
Copy link
Contributor

New response:

{
	"data": {
		"jobId": "success"
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng Ticket requires engineering work, other labels for specific backend or frontend
Projects
None yet
Development

No branches or pull requests

2 participants